Add status + scheduled to pages + blog posts #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courcelan
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
LGTM.
@ViolanteCodes Yes, the typings here dictate that status can only be one of those three strings
ViolanteCodes
changed the base branch from
master
to
2549-add-v2-typings-to-js-sdk
…s_to_blogs_pages_feature_2227
ViolanteCodes
deleted the
add_scheduled_status_to_blogs_pages_feature_2227
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place I could see where the actual fields content is indicated in any way is the ts file - I'm guessing because of typing?