fix: v2 export issue #107
Merged
fix: v2 export issue #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@courcelan can you take a look at this when you get a chance? Thank you |
marcinpece-apptension
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Issue with importing solved. 🎉
I approved, but let @courcelan or @ViolanteCodes look at it too
https://share.zight.com/RBuRD4KB
|
@marcinpece-apptension i don't see anywhere else we are using this feature, unless i am missing something. Are you seeing anywhere? I imagined we moved over to either css or bootstrap for smooth scrolling at some point when it was necessary? WDYT? |
|
I guess you ask here about other PR |
Yes 🤦 |
courcelan
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #97 and resolves #105.
It split builds into UMD and ES module builds which ensures
import Butter from "buttercms"works.It also adds development builds and leverages Tenser plugin for webpack instead of uglify.
Along this, it updates dependencies, as shown in table bellow:
Overview of version changes: