add in full cause to thrown errors #94
Conversation
courcelan
force-pushed
the
93-provide-error-status-code
branch
from
6a56058
to
189cbf4
Compare
|
@courcelan can you update the commit message to use |
removes auth_token from reporting update tests
courcelan
force-pushed
the
93-provide-error-status-code
branch
from
341b027
to
6ede5e4
Compare
done |
lib/useButter.js
Outdated
| @@ -123,18 +123,38 @@ export default function useButter(type, butterConfig) { | |||
| detail: errorDetail | |||
There was a problem hiding this comment.
In some cases error detail might be not in detail prop. Should we cover somehow or current state is ok?
https://share.zight.com/8LuNRWmL
There was a problem hiding this comment.
thanks for this @marcinpece-apptension, I've updated the code to handle a more general set of error keys/values. Please give this all another check.
| const errors = await errorPayload.response.json(); | ||
|
|
||
| const mappedParams = Object.fromEntries( | ||
| Object.entries(errorPayload.params) | ||
| .filter(([key]) => key !== 'auth_token') | ||
| ); | ||
|
|
||
| const url = new URL(errorPayload.response.url); | ||
|
|
||
| // Remove auth_token from URL search params | ||
| url.searchParams.delete('auth_token'); | ||
|
|
||
| const cause = { | ||
| data: errors, | ||
| headers: errorPayload.response.headers, | ||
| status: errorPayload.response.status, | ||
| statusText: errorPayload.response.statusText, | ||
| config: errorPayload.config, | ||
| params: mappedParams, | ||
| type, | ||
| url | ||
| }; |
| @@ -129,7 +129,7 @@ test( | |||
| catch (error) { | |||
| await expect(error).toBeDefined(); | |||
| await expect(error).toBeInstanceOf(Error); | |||
| await expect(error.message).toEqual("Error: Not found"); | |||
| await expect(error.message).toEqual("Error: Not found (404)"); | |||
There was a problem hiding this comment.
I have one error while running tests https://share.zight.com/L1uEo6mm
|
@ViolanteCodes Has the error in the test been fixed before merge? |
|
@marcinpece-apptension yes. I caught it in #95 and updated there prior to you mentioning it. so we should be all good. |
|
Cool 🎉 Thanks |
this PR (for issue #93) updates the reporting for a thrown Error.
Errors now report with the following:
err.message: the detail of the error and status codeerr.cause: info on what was passed to the APIerr.causecontains:data: the detail of the errorheaders: any headersstatus: response status codestatusText: any response status textconfig: the configuration used in the fetchparams: any parameters passed to the requestype: the content type requestedurl: object contain theURLschemaPlease note that any reference to
auth_tokenis removed from the resulting cause.