🎉 Adds kernel menu to control kernel #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisFederico
requested changes
Feb 19, 2022
pyflow/graphics/window.py
Outdated
Comment on lines
602
to
620
| def stop_kernel(self): | ||
| """Stop the kernel.""" | ||
| current_window = self.activeMdiChild() | ||
| if current_window is not None: | ||
| current_window.scene.kernel.stop() | ||
| self.reset_block_states() | ||
| self.statusbar.showMessage("Kernel stopped") | ||
| else: | ||
| self.statusbar.showMessage("No active window") | ||
|
|
||
| def restart_kernel(self): | ||
| """Restart the kernel.""" | ||
| current_window = self.activeMdiChild() | ||
| if current_window is not None: | ||
| current_window.scene.kernel.restart() | ||
| self.reset_block_states() | ||
| self.statusbar.showMessage("Kernel restarted") | ||
| else: | ||
| self.statusbar.showMessage("No active window") |
There was a problem hiding this comment.
Those functions are nearly the same, try to reduce duplication by using an other (private) method
|
Restarting the kernel introduces weird bugs. For example: I ran A then restarted the kernel and ran B. B should output an error but does not. Plus I would need to reset the kernel CWD every time I restart the kernel which means accessing saving_path from where I restart the kernel. I am closing this PR for the time being |
|
That's sad, this would be a very nice feature :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #274