Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail in tests on truncating pre-existing user files #126

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fail in tests on truncating pre-existing user files #126

merged 3 commits into from
Dec 4, 2024

Conversation

eugenesvk
Copy link
Contributor

@eugenesvk eugenesvk commented Dec 4, 2024 •
edited
Loading

create has a tiny chance of deleting existing files, so just in case replaced with create_new, which fails in this case

and will truncate it if it does

not sure what how tests re. lifetimes are related to these changes

Byron
Byron requested changes Dec 4, 2024
View reviewed changes
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Could you fix the clippy test as well so CI can be green again?
Thanks again.

Byron
Byron approved these changes Dec 4, 2024
View reviewed changes
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help!

@Byron Byron merged commit 823f6fb into Byron:master Dec 4, 2024
4 checks passed
@eugenesvk eugenesvk deleted the fr-test-file-new branch December 4, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugenesvk @Byron