Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fs_time_deleted attribute to TrashItem #79

Closed
wants to merge 2 commits into from
Closed

Added fs_time_deleted attribute to TrashItem #79

wants to merge 2 commits into from

Conversation

ramsteak
Copy link

@ramsteak ramsteak commented Jul 8, 2023

The attribute allows to access the filesystem timeformat without converting back and forth

ramsteak added 2 commits July 7, 2023 23:55
@ramsteak
Added fs_time_deleted attribute to TrashItem
c4f4f83 
The attribute allows to access the filesystem timeformat without converting
back and forth
@ramsteak
Formatting error
691d6a5
@ramsteak
Copy link
Author

ramsteak commented Jul 8, 2023

This pull request addresses issue #78

@ramsteak ramsteak mentioned this pull request Jul 8, 2023
Open
Byron
Byron requested changes Jul 9, 2023
View reviewed changes
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this.

Right now this PR seems to be a prototype as documentation is missing while there is commented-out code.

I'd appreciate if an existing test was adjusted to 'benefit' from the new field as well, show it off if you will.

Thank you.

src/windows.rs
Ok(time_u64)
}

fn date_fs_to_unix(date: &u64) -> Result<i64, Error> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date should not be a reference.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I'm at my very beginning of my rust and git/github journey, so I'm not really sure of what I am doing.

@ramsteak ramsteak closed this by deleting the head repository Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramsteak @Byron