-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update ci job to use cargo-cross #90
Conversation
Fails to link for
I'm not familiar with |
762cc8c
to
05ee139
Compare
Seemed to be this: cross-rs/cross#1345 Pushed a fix |
05ee139
to
f885a91
Compare
33d46f2
to
c335921
Compare
This works when I change from I'd suggest trying to reproduce the test failure on a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for getting NetBSD testing started!
Maybe for now, like you suggested, you could parameterize the test
portion in cargo test
so it can be build
with NetBSD and test
with everything else.
That way we wouldn't loose any test-coverage, validate builds in NetBSD while allowing tests to be enabled by contribution (CC @0323pin maybe) later.
I ran the tests locally in my |
c335921
to
da47b3f
Compare
da47b3f
to
be43b09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your help, it's much appreciated!
@@ -51,3 +51,14 @@ windows = { version = "0.44.0", features = [ | |||
"Win32_UI_Shell_PropertiesSystem", | |||
] } | |||
scopeguard = "1.2.0" | |||
|
|||
# workaround for https://github.com/cross-rs/cross/issues/1345 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we can keep an eye on this issue to eventually remove the workaround.
🚀 ❤️ |
WIP PR to support cargo cross (for netbsd). See #87
cc @0323pin @Byron