Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft for experimental plugin implementation #1153

Closed
wants to merge 17 commits into from

Conversation

lbianchi-lbl
Copy link
Contributor

Resolves (partially): #1085

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl
Copy link
Contributor Author

This is just an example at the moment, but here's how it looks like if we add an explicit check for PSUADE in sdoeSetupFrame.py:

image

The FOQUS interface starts as usual, but the SDoE frame won't be loaded. Eventually we'd also want the corresponding icon in the toolbar to be grayed out and/or display an error message/icon, but that require further work to move the code that loads the QAction for each frame from their current location in mainWindow.py to each plugin's module.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
foqus_lib/gui/basic_data/basicDataParentFrame.py 72.00% <100.00%> (+5.33%) ⬆️
foqus_lib/gui/flowsheet/drawFlowsheet.py 60.39% <100.00%> (+1.16%) ⬆️
foqus_lib/gui/main/Dash.py 51.13% <100.00%> (+2.98%) ⬆️
foqus_lib/gui/main/settingsFrame.py 29.88% <100.00%> (+2.01%) ⬆️
foqus_lib/gui/optimization/optSetupFrame.py 55.55% <100.00%> (+1.04%) ⬆️
foqus_lib/gui/ouu/ouuSetupFrame.py 55.04% <100.00%> (+0.30%) ⬆️
foqus_lib/gui/sdoe/sdoeSetupFrame.py 31.36% <100.00%> (+0.12%) ⬆️
foqus_lib/gui/surrogate/surrogateFrame.py 51.20% <100.00%> (+0.89%) ⬆️
foqus_lib/gui/uq/uqSetupFrame.py 41.36% <100.00%> (+0.27%) ⬆️
setup.py 0.00% <ø> (ø)
... and 1 more

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants