-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Surrogate Modeling Toolbox Machine Learning (GENN) Models #1169
Conversation
There is one expected error. The "Build docs" check will fail until #1164 is merged, as the documentation in this PR includes a reference to a page that is added in the Gradient Generation PR. The "ReadTheDocs" check will fail for the same reason. The reference that doesn't exist yet is called |
Codecov ReportAttention:
... and 15 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I left one minor suggestion which is fully optional
- The rest of the code and docs looks fine as far as I could tell from a quick skim
…to mlai-smt-support
I've just checked, and the minor drop in code coverage seems to be coming from error handling code being added (and I'm not sure whether this is also due to part of the report still missing), so I'm merging this in. |
Fixes/Addresses:
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: