Pull request template added

.github/pull_request_template.md

@@ -0,0 +1,30 @@
+## Notes
+
+Please include a summary of the change and which issue is fixed or which feature is added. 
+
+## JIRA
+
+- **Related story**: [Jira Ticket](url)
+
+## Checklist
+
+- [ ] PR focuses on a single story.
+- [ ] New unit tests added and ensured they pass.
+- [ ] Service has been tested in local and it works as expected.
+- [ ] Documentation has been updated for this code change (if needed).
+- [ ] Code follows the Java Coding Conventions (https://www.oracle.com/java/technologies/javase/codeconventions-programmingpractices.html).
+
+## Types of changes
+
+What types of changes does this PR introduces?
+
+- [ ] Bugfix
+- [ ] New feature
+- [ ] Breaking change
+
+## Testing
+
+- [ ] Does this PR has >90% code coverage?
+- [ ] Is the screenshot attached for code coverage?
+- [ ] Does the `gradle build` pass in your local? 
+- [ ] Is the `gradle build` logs attached?

data-ingestion-service/src/test/java/gov/cdc/dataingestion/ecr/service/EcrMessagePollServiceTest.java

@@ -39,7 +39,7 @@ void setUp() {
     }
 
     @Test
-    void fetchMessageContainerData_WithValidResult_ShouldProcessAndSave() throws EcrCdaXmlException {
+    void testFetchMessageContainerDataWithValidResult() throws EcrCdaXmlException {
         EcrSelectedRecord mockRecord = mock(EcrSelectedRecord.class);
         when(mockRecord.getMsgContainer()).thenReturn(ecrMsgContainerDto);
         when(mockRecord.getMsgContainer().getNbsInterfaceUid()).thenReturn(123456);
@@ -54,7 +54,7 @@ void fetchMessageContainerData_WithValidResult_ShouldProcessAndSave() throws Ecr
     }
 
     @Test
-    void fetchMessageContainerData_WithNullResult_ShouldNotProcess() throws EcrCdaXmlException {
+    void testFetchMessageContainerDataWithNullResult() throws EcrCdaXmlException {
         when(ecrMsgQueryService.getSelectedEcrRecord()).thenReturn(null);
 
         ecrMessagePollService.fetchMessageContainerData();
@@ -64,7 +64,7 @@ void fetchMessageContainerData_WithNullResult_ShouldNotProcess() throws EcrCdaXm
     }
 
     @Test
-    void fetchMessageContainerData_WithEcrCdaXmlException_ShouldThrow() throws EcrCdaXmlException {
+    void testFetchMessageContainerDataWithEcrCdaXmlException() throws EcrCdaXmlException {
         EcrSelectedRecord mockRecord = mock(EcrSelectedRecord.class);
         when(mockRecord.getMsgContainer()).thenReturn(ecrMsgContainerDto);
         when(mockRecord.getMsgContainer().getNbsInterfaceUid()).thenReturn(123456);

data-ingestion-service/src/test/java/gov/cdc/dataingestion/rawmessage/controller/EcrReportsControllerTest.java

@@ -27,7 +27,7 @@ class EcrReportsControllerTest {
     private NbsRepositoryServiceProvider nbsRepositoryServiceProvider;
 
     @Test
-    void testSaveIncomingEcr_WithRR() throws Exception {
+    void testSaveIncomingEcrWithRR() throws Exception {
         String payload = "<eICRXML>eicrContent</eICRXML><RRXML>rrContent</RRXML>";
         NbsInterfaceModel mockModel = new NbsInterfaceModel();
         mockModel.setNbsInterfaceUid(123456);
@@ -49,7 +49,7 @@ void testSaveIncomingEcr_WithRR() throws Exception {
     }
 
     @Test
-    void testSaveIncomingEcr_WithoutRR() throws Exception {
+    void testSaveIncomingEcrWithoutRR() throws Exception {
         String payload = "<eICRXML>eicrContent</eICRXML><RRXML>null</RRXML>";
         NbsInterfaceModel mockModel = new NbsInterfaceModel();
         mockModel.setNbsInterfaceUid(123456);
@@ -70,7 +70,7 @@ void testSaveIncomingEcr_WithoutRR() throws Exception {
     }
 
     @Test
-    void testSaveIncomingEcr_WithMalformedXml_ShouldReturnInternalServerError() throws Exception {
+    void testSaveIncomingEcrWithMalformedXml() throws Exception {
         String payload = "invalidXmlContent";
 
         mockMvc.perform(MockMvcRequestBuilders.post("/api/ecrs")