Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow update #252

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Workflow update #252

merged 13 commits into from
Dec 13, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Dec 11, 2024

Notes

  1. Updates the Build-and-deploy-data-ingestion-and-processing.yaml workflow to trigger based on paths so modifications to deduplication service does not deploy new processing / ingestion containers.
  2. Updates sonar.yaml to pass secret for database username and password
  3. Updates sonar.yaml to pull database container for use with deduplication

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@mpeels mpeels changed the title Workflow update <WIP> Workflow update Dec 11, 2024
@mpeels mpeels marked this pull request as ready for review December 11, 2024 20:39
@mpeels mpeels merged commit cdfa6b5 into main Dec 13, 2024
3 checks passed
@mpeels mpeels deleted the test-container-use-nbs-db branch December 13, 2024 17:30
snehaasjournal pushed a commit that referenced this pull request Dec 31, 2024
* Seed process in deduplication service

* Some unit testing. Resolve code smell?

* Placeholder tests

* Use test containers for nbs and mpi db

* Fix tab v spacing in build.gradle

* Use restored  MSSQL test container database for testing

* Remove merge duplicate

* Correct parameter

* EOF newlines

* Fix property name

* Run build on srte-data-service or phdc change

---------

Co-authored-by: Michael Peels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants