-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow update #252
Merged
Merged
Workflow update #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeels
requested review from
ndduc01,
rshanmugam-enquizit,
snehaasjournal and
ssathiah
December 11, 2024 20:36
snehaasjournal
approved these changes
Dec 11, 2024
Quality Gate passedIssues Measures |
snehaasjournal
pushed a commit
that referenced
this pull request
Dec 31, 2024
* Seed process in deduplication service * Some unit testing. Resolve code smell? * Placeholder tests * Use test containers for nbs and mpi db * Fix tab v spacing in build.gradle * Use restored MSSQL test container database for testing * Remove merge duplicate * Correct parameter * EOF newlines * Fix property name * Run build on srte-data-service or phdc change --------- Co-authored-by: Michael Peels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Build-and-deploy-data-ingestion-and-processing.yaml
workflow to trigger based on paths so modifications to deduplication service does not deploy new processing / ingestion containers.sonar.yaml
to pass secret for database username and passwordsonar.yaml
to pull database container for use with deduplicationChecklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle build
pass in your local?gradle build
logs attached?