-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CND-94 pt 2 - Feature flag modernized deduplication #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion check. Default: false
… unit tests for modernized matching
mpeels
changed the title
CND-94 pt 2 - Feature flag modernized deduplication <WIP>
CND-94 pt 2 - Feature flag modernized deduplication
Dec 17, 2024
Quality Gate passedIssues Measures |
ndduc01
approved these changes
Dec 19, 2024
snehaasjournal
pushed a commit
that referenced
this pull request
Dec 31, 2024
* Add api call for matching * Fix code smell / bug * Update PatientMatchingService with feature flag to use new deduplication check. Default: false * Remove possible null * Fix bug * Split deduplication call into service to ease testing. Add additional unit tests for modernized matching * More testing * Response test * Clean up some awkward logic * Improved test coverage * Fix jurisdiction code lookup --------- Co-authored-by: Michael Peels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
a. Feature flag defaults to
false
so existing patient match logic will be used.b. If the flag is set to
true
, then an API call will be made to the deduplication service to perform a patient match check.JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle build
pass in your local?gradle build
logs attached?