Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CND-94 pt 2 - Feature flag modernized deduplication #259

Merged
merged 13 commits into from
Dec 19, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Dec 13, 2024

Notes

  1. Adds a feature flag to the PatientMatchingService to support modernized patient matching.
    a. Feature flag defaults to false so existing patient match logic will be used.
    b. If the flag is set to true, then an API call will be made to the deduplication service to perform a patient match check.
  2. Resolves a whole host of sonar findings within PatientMatchingService.
  3. Adds additional test coverage

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@mpeels mpeels changed the title CND-94 pt 2 - Feature flag modernized deduplication <WIP> CND-94 pt 2 - Feature flag modernized deduplication Dec 17, 2024
@mpeels mpeels marked this pull request as ready for review December 17, 2024 17:18
@mpeels mpeels merged commit ffce196 into main Dec 19, 2024
3 checks passed
@mpeels mpeels deleted the CND-94-feature-flag-matching-service branch December 19, 2024 16:43
snehaasjournal pushed a commit that referenced this pull request Dec 31, 2024
* Add api call for matching

* Fix code smell / bug

* Update PatientMatchingService with feature flag to use new deduplication check. Default: false

* Remove possible null

* Fix bug

* Split deduplication call into service to ease testing. Add additional unit tests for modernized matching

* More testing

* Response test

* Clean up some awkward logic

* Improved test coverage

* Fix jurisdiction code lookup

---------

Co-authored-by: Michael Peels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants