Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNDE-1950: F_STD_PAGE_CASE Postprocessing #105

Merged
merged 5 commits into from
Dec 6, 2024
Merged

CNDE-1950: F_STD_PAGE_CASE Postprocessing #105

merged 5 commits into from
Dec 6, 2024

Conversation

johneipe
Copy link
Collaborator

@johneipe johneipe commented Dec 5, 2024

Notes

Added F_STD_PAGE_CASE post processing logic to populate the fact table

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

sveselev
sveselev approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@sveselev sveselev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

joshua-mills-cdw
joshua-mills-cdw approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@joshua-mills-cdw joshua-mills-cdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johneipe johneipe marked this pull request as ready for review December 6, 2024 21:34
@johneipe johneipe merged commit 99d92e6 into main Dec 6, 2024
3 checks passed
@sveselev sveselev deleted the CNDE-1950 branch December 16, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upasanapattnaik-eq upasanapattnaik-eq upasanapattnaik-eq left review comments

@joshua-mills-cdw joshua-mills-cdw joshua-mills-cdw approved these changes

@sveselev sveselev sveselev approved these changes

@rseshadri99 rseshadri99 Awaiting requested review from rseshadri99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johneipe @sveselev @upasanapattnaik-eq @joshua-mills-cdw