Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE-1982: Update port information #110

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

upasanapattnaik-eq
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq commented Dec 10, 2024

Notes

Please include a summary of the change and which issue is fixed or which feature is added.

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

Copy link
Collaborator

@rshanmugam-enquizit rshanmugam-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but hold on to this until Helm chart PR is approved and merged as it will break the services.

@upasanapattnaik-eq upasanapattnaik-eq marked this pull request as ready for review December 11, 2024 18:09
Copy link
Collaborator

@rshanmugam-enquizit rshanmugam-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@rshanmugam-enquizit rshanmugam-enquizit merged commit 058cb61 into main Dec 11, 2024
3 checks passed
@sveselev sveselev deleted the CNDE-1982-port-changes branch December 16, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants