Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE-2043 #126

Merged
merged 4 commits into from
Jan 2, 2025
Merged

CNDE-2043 #126

merged 4 commits into from
Jan 2, 2025

Conversation

joshua-mills-cdw
Copy link
Collaborator

Notes

nrt_interview_key and nrt_interview_note_key tables are being truncated on updates through liquibase. This needs to be fixed as the target tables do not maintain the key-uid relationship.

As part of this PR, I also removed a SELECT statement from sp_d_interview_postprocessing that caused the stored procedure to return data when it did not actually need to.

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@joshua-mills-cdw joshua-mills-cdw marked this pull request as ready for review December 30, 2024 21:41
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note to also update the db/update 🏎️

@joshua-mills-cdw
Copy link
Collaborator Author

Quick note to also update the db/update 🏎️

Done (in two commits because I forgot the sproc in the first), thanks!

Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshua-mills-cdw joshua-mills-cdw merged commit 1b69d25 into main Jan 2, 2025
joshua-mills-cdw added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants