-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNDE-2043 #126
CNDE-2043 #126
Conversation
liquibase-service/src/main/resources/db/rdb_modern/tables/022-create_nrt_interview_key-001.sql
Show resolved
Hide resolved
liquibase-service/src/main/resources/db/rdb_modern/tables/022-create_nrt_interview_key-001.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick note to also update the db/update 🏎️
Done (in two commits because I forgot the sproc in the first), thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Notes
nrt_interview_key and nrt_interview_note_key tables are being truncated on updates through liquibase. This needs to be fixed as the target tables do not maintain the key-uid relationship.
As part of this PR, I also removed a SELECT statement from sp_d_interview_postprocessing that caused the stored procedure to return data when it did not actually need to.
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle build
pass in your local?gradle build
logs attached?