Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all extended made into compact #2114

Merged
merged 3 commits into from
Dec 30, 2024
Merged

all extended made into compact #2114

merged 3 commits into from
Dec 30, 2024

Conversation

alaapbharadwaj
Copy link
Collaborator

@alaapbharadwaj alaapbharadwaj commented Dec 17, 2024

Description

All extended form inputs are now compact

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

hclarkEnq
hclarkEnq previously approved these changes Dec 17, 2024
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Would it make sense to treat sizing the same as orientation where it can be defined by the user of the component?

benlam-ignw
benlam-ignw previously approved these changes Dec 20, 2024
@alaapbharadwaj alaapbharadwaj merged commit e1d49ac into main Dec 30, 2024
1 check passed
@alaapbharadwaj alaapbharadwaj deleted the extended-compact-fields branch December 30, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants