Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarQube code smell resolution #2123

Merged
merged 2 commits into from
Dec 20, 2024
Merged

SonarQube code smell resolution #2123

merged 2 commits into from
Dec 20, 2024

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Dec 19, 2024 •
edited
Loading

Description

Resolves a few outstanding code smells found from Sonar scans.

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adamloup-enquizit adamloup-enquizit marked this pull request as ready for review December 19, 2024 15:55
@adamloup-enquizit adamloup-enquizit merged commit 2b98222 into main Dec 20, 2024
3 checks passed
@adamloup-enquizit adamloup-enquizit deleted the sonar branch December 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeaxcdw joeaxcdw joeaxcdw approved these changes

@stevegsa stevegsa stevegsa approved these changes

@alaapbharadwaj alaapbharadwaj Awaiting requested review from alaapbharadwaj

@mpeels mpeels Awaiting requested review from mpeels mpeels is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamloup-enquizit @stevegsa @joeaxcdw