-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cnft1 3377 UI new patient extended default value and first option for country should be united states of america #2128
Merged
benlam-ignw
merged 11 commits into
main
from
CNFT1-3377-UI-New-patient-Extended-Default-value-and-first-option-for-country-should-be-United-States-of-America
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlam-ignw
requested review from
adamloup-enquizit and
mpeels
as code owners
December 20, 2024 15:57
joeaxcdw
previously approved these changes
Dec 20, 2024
…alue-and-first-option-for-country-should-be-United-States-of-America
…g the duplication issue
…rst-option-for-country-should-be-United-States-of-America' of https://github.com/CDCgov/NEDSS-Modernization into CNFT1-3377-UI-New-patient-Extended-Default-value-and-first-option-for-country-should-be-United-States-of-America
stevegsa
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! We can do a global default for country in a followup story.
…alue-and-first-option-for-country-should-be-United-States-of-America
Quality Gate passedIssues Measures |
joeaxcdw
approved these changes
Dec 20, 2024
adamloup-enquizit
deleted the
CNFT1-3377-UI-New-patient-Extended-Default-value-and-first-option-for-country-should-be-United-States-of-America
branch
December 30, 2024 14:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the default in the address entry repeating block US, and then manually add the US entry to the collection before adding all the other entries so the US is always on top.
Tickets
Checklist before requesting a review