Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cnft1 3377 UI new patient extended default value and first option for country should be united states of america #2128

Conversation

benlam-ignw
Copy link
Collaborator

Description

Make the default in the address entry repeating block US, and then manually add the US entry to the collection before adding all the other entries so the US is always on top.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

joeaxcdw
joeaxcdw previously approved these changes Dec 20, 2024
…alue-and-first-option-for-country-should-be-United-States-of-America
…rst-option-for-country-should-be-United-States-of-America' of https://github.com/CDCgov/NEDSS-Modernization into CNFT1-3377-UI-New-patient-Extended-Default-value-and-first-option-for-country-should-be-United-States-of-America
Copy link
Collaborator

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! We can do a global default for country in a followup story.

…alue-and-first-option-for-country-should-be-United-States-of-America
@benlam-ignw benlam-ignw requested a review from joeaxcdw December 20, 2024 19:42
@benlam-ignw benlam-ignw merged commit 4b001bf into main Dec 20, 2024
4 checks passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-3377-UI-New-patient-Extended-Default-value-and-first-option-for-country-should-be-United-States-of-America branch December 30, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants