Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNFT1-3638]: fixing height for race field #2129

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

hclarkEnq
Copy link
Collaborator

@hclarkEnq hclarkEnq commented Dec 20, 2024

Description

Height of the multi-select drop-down box should match the Race field so set min height to 2.5 rem

Screenshot 2024-12-20 at 3 58 05 PM

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@hclarkEnq hclarkEnq marked this pull request as ready for review December 20, 2024 17:26
joeaxcdw
joeaxcdw previously approved these changes Dec 20, 2024
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a slightly rounded border on the multi-select?

@hclarkEnq
Copy link
Collaborator Author

is there a slightly rounded border on the multi-select?

yess good catch going to fix now

@hclarkEnq hclarkEnq merged commit 7b21215 into main Dec 20, 2024
1 check passed
@hclarkEnq hclarkEnq deleted the CNFT1-3638-race-field-height-fix-extended branch December 30, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants