Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNFT1-3642] Incorporated verification into form library #2130

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Dec 20, 2024

Description

Changes the Verification component and useVerification hook to tie into react-hook-form control to be able to clear when needed.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

joeaxcdw
joeaxcdw previously approved these changes Dec 20, 2024
Copy link
Collaborator

@joeaxcdw joeaxcdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be some minor reorganization of the unit tests around validate email and related changes.

@adamloup-enquizit adamloup-enquizit merged commit 3620e76 into main Dec 30, 2024
1 check passed
@adamloup-enquizit adamloup-enquizit deleted the CNFT1-3642-non-blocking-message branch December 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants