Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNFT1-3610: Search results pluralize fix #2131

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

joeaxcdw
Copy link
Collaborator

Description

Pluralize "results" for text and aria-label. Create pluralize() function for use across the app in other places.

image

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@joeaxcdw joeaxcdw changed the title CNFT1-3610: search results pagination fix CNFT1-3610: Search results pluralize fix Dec 20, 2024
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@joeaxcdw joeaxcdw merged commit 1c5837d into main Dec 20, 2024
1 check passed
@joeaxcdw joeaxcdw deleted the CNFT1-3610-search-results-pagination-fix branch December 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants