Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNFT1-3604 API: New patient- Extended: Race: Detailed Race: Drop down… #2134

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

stevegsa
Copy link
Collaborator

@stevegsa stevegsa commented Dec 23, 2024

Description

Replace the order by with code instead of code_short_desc_txt.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

Proof that the order for detailed race matches the story for each individual race category:

select
  r2.code_short_desc_txt as Race,
  r1.code_short_desc_txt as 'Detailed Race'
from Race_code r1 
  join Race_code r2 on r1.parent_is_cd=r2.code
where
  r1.parent_is_cd in ('2106-3','2054-5','2076-8','1002-5')
order by
  r1.indent_level_nbr,
  r1.code

Screenshot 2024-12-22 at 9 33 41 PM

@stevegsa stevegsa merged commit 4703ec7 into main Dec 30, 2024
3 checks passed
@adamloup-enquizit adamloup-enquizit deleted the steveu-api-detailed-race-ordering branch December 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants