add daily_to_weekly function #478
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 96.52% 96.56% +0.04%
==========================================
Files 41 41
Lines 949 962 +13
==========================================
+ Hits 916 929 +13
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you for your contribution @dylanhmorris 🚀! Your github-pages is ready for download 👉 here 👈! |
There was a problem hiding this comment.
Perhaps I've misread, but this appears to use ISO epiweeks (Monday start, Sunday end). Much of our work will involve USA epiweeks (Sunday start, Saturday end). That said, it looks to me as though it would not be much extra work to make this into a general daily-to-weekly function (i.e. both the start dow of the weekly aggregates and the start dow of the input timeseries are configurable).
Agree / disagree @sbidari?
Co-authored-by: Dylan H. Morris <[email protected]>
|
Ready for re-review @dylanhmorris |
There was a problem hiding this comment.
A few wording suggestions. Implementation looks good! Thanks @sbidari!
Co-authored-by: Dylan H. Morris <[email protected]>
| Data converted to weekly values starting | ||
| with the first full week available. | ||
| """ | ||
| if input_data_first_dow < 0 or input_data_first_dow > 6: |
There was a problem hiding this comment.
In the future we may want to enforce integer-like values more strongly or conversely expand to support arrays of different potentially, but I think this is fine for now.
dylanhmorris
deleted the
477-aggregate-daily-predicted-incident-hospitalization-to-epiweekly
branch
No description provided.