Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Features and Blocking Keys for phone and email #148

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Dec 11, 2024

Description

Add features and blocking keys for the telecom phone number and email values

Related Issues

closes #147

Additional Notes

The work in #26 suggested also making SSN a blocking key, however since the ongoing work on id triplets (#133) will redo the implementation of SSN and also make it a blocking key per RFC-001, this work has been intentionally left out of this PR.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (3a7e58b) to head (a7671ff).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   97.15%   97.21%   +0.05%     
==========================================
  Files          30       30              
  Lines        1301     1327      +26     
==========================================
+ Hits         1264     1290      +26     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review December 11, 2024 00:42
@ericbuckley ericbuckley merged commit c07aea2 into main Dec 16, 2024
12 checks passed
@ericbuckley ericbuckley deleted the feature/147-telecom-blockingkeys branch December 16, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement telecom blocking keys
2 participants