Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RV-417): Use local storage as fallback from api #418

Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat(RV-417): Use local storage as fallback from api #418

merged 3 commits into from
Nov 21, 2024

Conversation

knguyenrise8
Copy link
Collaborator

Description

Uses local storage as a fallback

Screenshots (if applicable)

Screen.Recording.2024-11-21.at.11.21.37.AM.mov

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

@knguyenrise8 knguyenrise8 force-pushed the feat/RV-417-use-localstorage-as-fallback branch from ccee1a0 to f6c0973 Compare November 21, 2024 18:11
schreiaj
schreiaj requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@schreiaj schreiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small code changes

frontend/src/components/TemplatesIndex/TemplatesIndex.tsx Outdated Show resolved Hide resolved
frontend/src/components/TemplatesIndex/TemplatesIndex.tsx Outdated Show resolved Hide resolved
frontend/src/components/TemplatesIndex/TemplatesIndex.tsx Outdated Show resolved Hide resolved
frontend/src/components/TemplatesIndex/TemplatesIndex.tsx Outdated Show resolved Hide resolved
frontend/src/components/TemplatesIndex/TemplatesIndex.tsx Outdated Show resolved Hide resolved
frontend/src/components/TemplatesIndex/TemplatesIndex.tsx Show resolved Hide resolved
@knguyenrise8 knguyenrise8 force-pushed the feat/RV-417-use-localstorage-as-fallback branch from f6c0973 to 0415bbf Compare November 21, 2024 18:24
@knguyenrise8 knguyenrise8 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 2ff6aa4 Nov 21, 2024
3 checks passed
@knguyenrise8 knguyenrise8 deleted the feat/RV-417-use-localstorage-as-fallback branch November 21, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schreiaj schreiaj schreiaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knguyenrise8 @schreiaj