Add middleware to App Gateway #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2024 12:29
marycrawford
reviewed
Dec 6, 2024
| api-name: ocr | ||
|
|
||
| deploy-ocr: | ||
| name: Deploy OCR | ||
| runs-on: ubuntu-latest | ||
| environment: ${{ inputs.deploy-env }} | ||
| environment: dev |
There was a problem hiding this comment.
Do we want to hardcode dev here? Or can we make dynamic so if whomever picks it up can select dev, as well as, stage or prod (after they build out those environments)?
There was a problem hiding this comment.
this is how we do local github action testing. I will make this a draft
There was a problem hiding this comment.
also wouldnt need to test like this if we create a seperate worflow for building and deploying the middleware
|
|
||
| path_rule { | ||
| name = "api" | ||
| name = "ocr" |
There was a problem hiding this comment.
Is the name just ocr or api_ocr?
There was a problem hiding this comment.
oh the name here doesn't really matter, just needs to be different than the middleware rule.
added 2 commits
December 6, 2024 09:34
added 11 commits
December 6, 2024 11:35
marycrawford
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forgot to add this on my previous PR
this should hopefully allow all the services to communicate properly 🤞
Screenshots (if applicable)
Related Issues
[Link any related issues or tasks from your project management system.]
Checklist