Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install torch by default #472

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Don't install torch by default #472

merged 3 commits into from
Dec 10, 2024

Conversation

jonchang
Copy link
Collaborator

@jonchang jonchang commented Dec 9, 2024 •
edited
Loading

Description

Don't install torch by default. This is a natural follow up to our decision in #414 (comment).

Related Issues

Part of #412.

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

@jonchang jonchang marked this pull request as ready for review December 9, 2024 20:24
@jonchang jonchang mentioned this pull request Dec 10, 2024
Open
@jonchang jonchang added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 878a409 Dec 10, 2024
3 checks passed
@jonchang jonchang deleted the no-torch branch December 10, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knguyenrise8 knguyenrise8 knguyenrise8 approved these changes

@derekadombek derekadombek derekadombek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonchang @derekadombek @knguyenrise8