Update Postgres DB and Add DB Variables to Middleware-Api #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
added 2 commits
December 10, 2024 22:49
marycrawford
changed the title
marycrawford
changed the title
derekadombek
previously approved these changes
Dec 11, 2024
| resource_group_name = var.resource_group | ||
| subnet_id = azurerm_subnet.db-subnet.id | ||
|
|
||
| private_service_connection { |
There was a problem hiding this comment.
This is giving me an error on my local. not sure why
There was a problem hiding this comment.
I removed the azurerm_private_endpoint resource, which can be an optional architectural design if we want a higher level security. To unblock the engineers and continue with e2e testing it is best to remove it. However, the communication of the network for the middleware and database respective delegations and app_settings allow it to communicate privately in the vnet.
marycrawford
dismissed stale reviews from derekadombek and arinkulshi-skylight
via
5fdafa9
added 2 commits
December 12, 2024 10:26
…all_rule for app_service
marycrawford
deleted the
revise-postgresdb-and-add-middleware-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update database module to include the server id and fqdn and ensure that the credentials of the database can be accessible to the middleware-api module.
azurerm_postgresql_flexible_server_firewall_ruleresource for added protection of the communication of the database and middleware app_service.azurerm_key_vaultresource and removing it from theazurermprovider features section.Related Issues
#478
Checklist