Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed cancel button on upload page #488

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fixed cancel button on upload page #488

merged 1 commit into from
Dec 18, 2024

Conversation

arinkulshi-skylight
Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight commented Dec 17, 2024 •
edited
Loading

Description

The cancel button was going to a 404. Fixed the cancel button to back to root of the app.

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

@arinkulshi-skylight arinkulshi-skylight changed the title fixed cancel button fixed cancel button on upload page Dec 17, 2024
zdeveloper
zdeveloper approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arinkulshi-skylight arinkulshi-skylight added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 92135c0 Dec 18, 2024
3 checks passed
@arinkulshi-skylight arinkulshi-skylight deleted the fixed_back_link_upload_page branch December 18, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdeveloper zdeveloper zdeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arinkulshi-skylight @zdeveloper