Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDWA-OPS-58] Fix OCR unit test trigger #67

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

derekadombek
Copy link
Collaborator

@derekadombek derekadombek commented Apr 4, 2024

Pull Request

Description

Before I had it setup so it was triggering on every upstream commit. To refine this workflow even more, this will trigger only after a PR is opened, synchronize, or reopened. synchronize is the type that will trigger for every commit after initial PR creation.

NOTE: These types are default to on: pull_request so theres no need to add them in the code.

Related Issues

#58

Additional Notes

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@derekadombek derekadombek changed the title [IDWA-OPS-58] Fix OCR unit test to trigger [IDWA-OPS-58] Fix OCR unit test trigger Apr 4, 2024
paths:
- .github/workflows/ocr-tests.yml
- OCR/**
push:
paths:
- .github/workflows/ocr-tests.yml
- OCR/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the quotes around the paths?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not. it works with or without. we can tho if thats what you prefer.

@derekadombek derekadombek requested a review from zdeveloper April 5, 2024 14:33
@derekadombek derekadombek added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 0284eab Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants