-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update engineering_spike.md #90
Conversation
Added sections to the existing template based on Research Spike Template draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -7,11 +7,40 @@ assignees: '' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above on line 5, the label is currently set with the OCR
label. So ATM(im pretty sure) this will only apply to issues being made for the OCR board, we probably could just add the dedupe
label and it should work for both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be best to replace whats currently in the idwa_dedupe.yml
with this new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekadombek I've removed the OCR label per @bryanbritten's suggestion in Slack:
FWIW I would prefer minimizing the number of "team-specific" resources that we use. The Research Spike Template is a good example of something that could be used across both teams, and would create consistency in how we track the work we're doing. My recommendation would be to simply remove the OCR label and request that any one creating a research spike ticket manually add the label for their team, and then the GH Action that Derek set up will take care of assigning it to the appropriate project.
Removed the `OCR` label from template so this can be used across both IDWA teams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as the person who has been the biggest user of the engineering spike template, I am not the biggest fan of the verbosity of this template, but I will probably end up removing some of the non-relevant sections.
closing this since its been open for too long |
Pull Request
Description
Added sections to the existing template based on Research Spike Template Proposal
Related Issues
N/A
Additional Notes
N/A
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: