Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity on use of Doc extension tools #126

Closed
SamuelBrand1 opened this issue Mar 8, 2024 · 4 comments
Closed

Clarity on use of Doc extension tools #126

SamuelBrand1 opened this issue Mar 8, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation EpiAware

Comments

@SamuelBrand1
Copy link
Collaborator

          I thought we were using the extension tools to manage the construction of the args documentation etc as you had in the original docs PR (and the other similar extension tools). It sounds like this is still in the air though so perhaps we need another discussion issue? What I mean is that yes we have the template but I thought when writing docstrings we would be automating large parts of them using the extension tools to make them less error prone (l;like the arg types).

Originally posted by @seabbs in #117 (comment)

@SamuelBrand1 SamuelBrand1 added documentation Improvements or additions to documentation EpiAware labels Mar 8, 2024
@SamuelBrand1
Copy link
Collaborator Author

My understanding is that we aim for this for type and function docstrings.

The way we get there is using docstringextensions, but descriptions like #Arguments need to go in the DOCSTRING for the template. The types of the arguments are found by TYPEDSIGNATURES.

@seabbs
Copy link
Collaborator

seabbs commented Mar 11, 2024

The way we get there is using docstringextensions, but descriptions like #Arguments need to go in the DOCSTRING for the template. The types of the arguments are found by TYPEDSIGNATURES.

Yes, issue is about using these which wasn't in the PR that this comment was pulled out of.

@seabbs
Copy link
Collaborator

seabbs commented Mar 11, 2024

Noting that the lack of clarity here is starting to lead to increasing amounts of technical debt as some features are being implemented without any documentation and most have different standards being used. We should aim to resolve this ASAP.

@SamuelBrand1
Copy link
Collaborator Author

I think we have clarity now.

DocStringExtensions.jl provides annotations in the the template macro but not used elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation EpiAware
Projects
None yet
Development

No branches or pull requests

2 participants