-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 53: First pass at differenced AR #128
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Any feedback before I push on? |
I'm still parsing this |
This is ready for review. I have added unit tests but given the blocker of #126 I think we need to wait for that for the documentation (which as noted is a serious issue). I have also opened a new PR for the differencing (#134 which I will address after this) and made an issue for the lack of consistency for positional args (#133). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; love the self-referencing approach to getting generic AR/diff AR!
I think the main AR
struct needs to be parametric, thats the only change I recommend.
I've updated w/ all suggestions. Note I have used |
@SamuelBrand1 pinging for review |
Reviewing this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only concern is that the method isn't robust to generating vector shaped damp
or ar_init
.
If this gets tested and works then I'm happy
This should be updated now following the approach suggested in #134 and rebased on main. Note I had to copy Moving on to #134 now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this.
…ith having defaults
This PR is ready for review and closes #53