Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include day of week effect in pipeline analysis #257

Closed
SamuelBrand1 opened this issue Jun 4, 2024 · 2 comments · Fixed by #264
Closed

Include day of week effect in pipeline analysis #257

SamuelBrand1 opened this issue Jun 4, 2024 · 2 comments · Fixed by #264
Labels
pipeline

Comments

@SamuelBrand1
Copy link
Collaborator 

          This looks great!

Wrt using softmax, I think that would be cool after we clear #251 e.g. we might model a weekly process but then broadcast out the weekly observations to a day of the week in a way that respects the weekly average obs.

This implementation hit a different form of modelling and looks nice!

Note: this was part of analysis plan and should now be added to pipeline.

Originally posted by @SamuelBrand1 in #253 (review)

As per title in light of this PR
@seabbs
Copy link
Collaborator

seabbs commented Jun 4, 2024

Linked to #258

@SamuelBrand1
Copy link
Collaborator Author

This is moving forward now #258 is closed.

@SamuelBrand1 SamuelBrand1 mentioned this issue Jun 7, 2024
Merged
@SamuelBrand1 SamuelBrand1 linked a pull request Jun 7, 2024 that will close this issue
Include day of week effect in pipeline analysis #264
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include day of week effect in pipeline analysis CDCgov/Rt-without-renewal
2 participants
@seabbs @SamuelBrand1