-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include day of week effect in pipeline analysis #264
Include day of week effect in pipeline analysis #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest using a .gitignore in truth data and adding these file types + getting rid of the placeholder file. Or do we want to commit this data as fixes the sims for onwards analysis?
I've added ignore *.jld2
files to gitignore
and if we commit this as a fix I think this works.
I started this branch before these changes were merged to main and squashed them into this branch. |
52e045b
to
af14884
Compare
That doesn't sound like the right git flow to me? I've rebase so maybe will fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased fixed the issue with old stuff here but commited files are still here. Are they meant to be?
I don't see any committed files except some placeholder.md files? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 45 45
Lines 451 451
=======================================
Hits 421 421
Misses 30 30 ☔ View full report in Codecov by Sentry. |
b9f5f10
to
aab078b
Compare
Small PR which implements the day of week observation effect introduced by #253 and #258 to the pipeline generative model. Also removes older "truth data" sims.
Closes #257 .