Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include day of week effect in pipeline analysis #264

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

Small PR which implements the day of week observation effect introduced by #253 and #258 to the pipeline generative model. Also removes older "truth data" sims.

Closes #257 .

@SamuelBrand1 SamuelBrand1 requested a review from seabbs June 7, 2024 12:13
@SamuelBrand1 SamuelBrand1 linked an issue Jun 7, 2024 that may be closed by this pull request
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using a .gitignore in truth data and adding these file types + getting rid of the placeholder file. Or do we want to commit this data as fixes the sims for onwards analysis?

I've added ignore *.jld2 files to gitignore and if we commit this as a fix I think this works.

EpiAware/src/EpiLatentModels/HierarchicalNormal.jl Outdated Show resolved Hide resolved
@SamuelBrand1
Copy link
Collaborator Author

This looks good but has there been a git history issue here? Looks like a bunch of changes I thought we had merged already.

I started this branch before these changes were merged to main and squashed them into this branch.

@seabbs seabbs force-pushed the 257-include-day-of-week-effect-in-pipeline-analysis branch from 52e045b to af14884 Compare June 7, 2024 13:58
@seabbs
Copy link
Collaborator

seabbs commented Jun 7, 2024

That doesn't sound like the right git flow to me? I've rebase so maybe will fix

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased fixed the issue with old stuff here but commited files are still here. Are they meant to be?

@SamuelBrand1
Copy link
Collaborator Author

Rebased fixed the issue with old stuff here but commited files are still here. Are they meant to be?

I don't see any committed files except some placeholder.md files?

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.34%. Comparing base (4688d20) to head (aab078b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files          45       45           
  Lines         451      451           
=======================================
  Hits          421      421           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs force-pushed the 257-include-day-of-week-effect-in-pipeline-analysis branch from b9f5f10 to aab078b Compare June 10, 2024 18:11
@seabbs seabbs enabled auto-merge (squash) June 10, 2024 18:11
@seabbs seabbs merged commit d7775dc into main Jun 11, 2024
10 checks passed
@seabbs seabbs deleted the 257-include-day-of-week-effect-in-pipeline-analysis branch June 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include day of week effect in pipeline analysis
3 participants