Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test EpiAware CI running very slowly #269

Closed
seabbs opened this issue Jun 10, 2024 · 9 comments
Closed

Test EpiAware CI running very slowly #269

seabbs opened this issue Jun 10, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@seabbs
Copy link
Collaborator

seabbs commented Jun 10, 2024

As can be seen here https://github.com/CDCgov/Rt-without-renewal/actions/workflows/test-EpiAware.yaml?query=branch:main

as of a recent update our test CI has started to run very slowly for no apparent reason. Do we have clarity on if this is on our side, or due to a dependency change. If it is due to a dependency change can we update our code (i.e to remove reliance on a depreciated feature) to speed the CI (and so potentially our package performance) back up

@seabbs seabbs added the bug Something isn't working label Jun 10, 2024
@SamuelBrand1
Copy link
Collaborator

Did this start after #262 ?

@SamuelBrand1
Copy link
Collaborator

Looking at current CI... The two Mac OS CI groups finished in 10 and 15 mins. And documenter (I guess built under Ubuntu) took 5 mins.

@seabbs
Copy link
Collaborator Author

seabbs commented Jun 11, 2024

It looks like we have a bunch of depreciations from #262 that could be causing problems? https://github.com/CDCgov/Rt-without-renewal/actions/runs/9462089214/job/26064276243#step:7:448

@SamuelBrand1
Copy link
Collaborator

Looking at completed CIs e.g. #268 It seems alot slower for microsoft and ubuntu.

@SamuelBrand1
Copy link
Collaborator

It looks like we have a bunch of depreciations from #262 that could be causing problems? https://github.com/CDCgov/Rt-without-renewal/actions/runs/9462089214/job/26064276243#step:7:448

I would think that this just creates some warnings; I don't think it explains the performance diff between different OS targets.

@SamuelBrand1
Copy link
Collaborator

This was true back here too? https://github.com/CDCgov/Rt-without-renewal/actions/runs/8736028303/usage

@seabbs
Copy link
Collaborator Author

seabbs commented Jun 11, 2024

I would think that this just creates some warnings; I don't think it explains the performance diff between different OS targets.

My wonder here is did they change something which caused them to depreciate motivated by other upstream changes that might explain the performance hit.

@SamuelBrand1
Copy link
Collaborator

test (1.10, ubuntu-latest) | 2h 11m 34s |  
test (1.10, windows-latest) | 45m 51s |  
test (1.10, macOS-latest) | 15m 45s

Latest complete CI... thats pretty wild.

@seabbs
Copy link
Collaborator Author

seabbs commented Jun 11, 2024

This looks to have been resolved by #272. This makes the point very strongly to me that we need either to have continuous benchmarks as part of the CI or watch runtimes more closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants