Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MvNormal constructor with FillArrays.Fill #272

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

Does as per title to close #271

@SamuelBrand1 SamuelBrand1 requested a review from seabbs June 11, 2024 12:23
@SamuelBrand1 SamuelBrand1 linked an issue Jun 11, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.34%. Comparing base (d7775dc) to head (61c8d78).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files          45       45           
  Lines         451      451           
=======================================
  Hits          421      421           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it fixes the performance issues seein in #269 which is great. The syntax really is getting horrible with these changes. Is using MvNormal still the recommendation in these simple independent cases?

@seabbs seabbs enabled auto-merge June 11, 2024 13:01
@seabbs seabbs added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 59a358b Jun 11, 2024
10 checks passed
@seabbs seabbs deleted the 271-fix-mvnormal-depreciation branch June 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MvNormal depreciation
3 participants