Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor away unnecessary pipeline methods #289

Closed
SamuelBrand1 opened this issue Jun 17, 2024 · 1 comment
Closed

Refactor away unnecessary pipeline methods #289

SamuelBrand1 opened this issue Jun 17, 2024 · 1 comment
Labels

Comments

@SamuelBrand1
Copy link
Collaborator

Generally, our pattern has been to control pipeline behaviour with methods dispatching on pipeline type. This is fine IMO, but as we've developed its become clear that we can control things without as many methods. For example, generate_inference_results: with a small refactor we don't need this to dispatch directly on pipeline type because the underlying function chooses its behaviour on pipeline dispatch.

This is low priority but IMO worth flagging.

@SamuelBrand1
Copy link
Collaborator Author

I think #295 has closed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant