-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example mode and unit tests for pipeline functions. #295
Conversation
…ditional unit testing
I've moved the dispatch on being the example mode pipeline to the constructor for the list of configutations to loop over. Good shout @seabbs it is cleaner this way. |
See my comment. I thought the solution was just calling the abstract method internally to the new method and then calling rand on that? |
That was the original pass which I didn't like; I don't want to make a method which internally generates its internal abstract super type. To me that is weird. for example: abstract type MyAbstractType end
struct AType <: MyAbstractType
end
function foo(pipe::MyAbstractType)
...
return list
end
function foo(pipe::AType)
list = foo(get_super_type(pipe))
return rand(list)
end
|
What about having a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Seems like a great solution.
I think a What I've just pushed is the creation of an internal Going forwards I think the way we have done the pipe leans into trait-based programming (cf |
Does as per title and closes #293