Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuee 98: Review and update exported functions #106

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Issuee 98: Review and update exported functions #106

merged 2 commits into from
Mar 6, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 1, 2024

This PR closes #98 by exporting all functions we expect a user (ourselves) to use if constructing a new model.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (bc87599) to head (8a4b41f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files           6        6           
  Lines         133      133           
=======================================
  Hits          130      130           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs
Copy link
Collaborator Author

seabbs commented Mar 5, 2024

The Document issue is unrelated to this PR and I think an issue with the templating that likely shouldn't have made it to main. @SamuelBrand1 do you agree with the proposed exports here?

Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit 93eb67c into main Mar 6, 2024
10 checks passed
@seabbs seabbs deleted the issue98 branch March 6, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review what is and isn't exported
3 participants