Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 51: First pass at broadcasting #171

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Issue 51: First pass at broadcasting #171

merged 10 commits into from
Mar 26, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 25, 2024

This PR partly resolves #51 by introducing a broadcasting approach to EpiLatentModels which can be used both for day of the week models and for piecewise constant latent models.

Depending on how we feel about this approach we may want to abstract some of this into its own module at some point to allow broadcasting in other parts of the code base.

It does not add the ascertainment EpiObsModel or Random EpiLatentModel which will be needed to full address #51.

@seabbs seabbs requested a review from SamuelBrand1 March 25, 2024 23:26
@seabbs seabbs enabled auto-merge (squash) March 25, 2024 23:27
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 95.43%. Comparing base (401e028) to head (cbcd087).

Files Patch % Lines
EpiAware/src/EpiAwareBase/functions.jl 0.00% 4 Missing ⚠️
EpiAware/src/EpiAwareBase/generate_models.jl 66.66% 3 Missing ⚠️
...Aware/src/EpiLatentModels/broadcast/latentmodel.jl 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   97.99%   95.43%   -2.56%     
==========================================
  Files          28       32       +4     
  Lines         249      285      +36     
==========================================
+ Hits          244      272      +28     
- Misses          5       13       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs
Copy link
Collaborator Author

seabbs commented Mar 26, 2024

Coverage is a bit low so I will address that but I think this is still good to review as is.

Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach, nice and flexible.

@seabbs seabbs requested a review from SamuelBrand1 March 26, 2024 12:06
@seabbs
Copy link
Collaborator Author

seabbs commented Mar 26, 2024

I think this addresses the coverage gaps and includes your suggestions.

@seabbs seabbs merged commit b12e482 into main Mar 26, 2024
10 checks passed
@seabbs seabbs deleted the issue51 branch March 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inclusion of day of week observation processes
3 participants