-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 51: First pass at broadcasting #171
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 97.99% 95.43% -2.56%
==========================================
Files 28 32 +4
Lines 249 285 +36
==========================================
+ Hits 244 272 +28
- Misses 5 13 +8 ☔ View full report in Codecov by Sentry. |
Coverage is a bit low so I will address that but I think this is still good to review as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, nice and flexible.
I think this addresses the coverage gaps and includes your suggestions. |
This PR partly resolves #51 by introducing a broadcasting approach to
EpiLatentModels
which can be used both for day of the week models and for piecewise constant latent models.Depending on how we feel about this approach we may want to abstract some of this into its own module at some point to allow broadcasting in other parts of the code base.
It does not add the ascertainment
EpiObsModel
orRandom
EpiLatentModel
which will be needed to full address #51.