Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 51: Adds Ascertainment #175

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Issue 51: Adds Ascertainment #175

merged 7 commits into from
Mar 28, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 27, 2024

This PR does further work on #51 by adding an ascertainment model to EpiObsModels. This just leaves specifying an appropriate latent process and link function which will be addressed in an open PR. one open question is whether or not we want a dayofweek helper function as a latent process or/and we want a observation model that specifies a link etc.

@seabbs seabbs requested a review from SamuelBrand1 March 27, 2024 21:10
@seabbs seabbs enabled auto-merge (squash) March 27, 2024 21:12
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (7943392) to head (3e53a71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   99.30%   99.31%   +0.01%     
==========================================
  Files          32       33       +1     
  Lines         287      293       +6     
==========================================
+ Hits          285      291       +6     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Makes sense.

@seabbs seabbs merged commit 6a6a1d4 into main Mar 28, 2024
10 checks passed
@seabbs seabbs deleted the issue51-2 branch March 28, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants