-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor pipeline smaller scripts and functions #217
refactor pipeline smaller scripts and functions #217
Conversation
…tion of small functions with unit tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 42 42
Lines 399 399
=======================================
Hits 370 370
Misses 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this. I had a few suggestions to make it more complicated/have more infra but not essential. We can discuss and port what we want to do into new issues and merge this I think
I've made a few minor changes:
#218 Should cover some of the more exciting ideas we could do with pipeline analysis going forwards! But I think this pipeline (which runs) is currently a good template to layer on the rest the tasks in #195 |
This PR aims to refactor, but not extend the functionality, of the analysis pipeline in such a way that:
Concretely,
AnalysisPipeline
module.make_...
functions from theAnalysisPipeline
module.targets.R
.Closes #215 .