Make the 99th perc default constructor a censored_pmf feature
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it a `censored_pmf` feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 92.84% 92.85% +0.01%
==========================================
Files 47 47
Lines 489 490 +1
==========================================
+ Hits 454 455 +1
Misses 35 35 ☔ View full report in Codecov by Sentry. |
|
Just caught the |
seabbs
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that follows on from #265. Whilst working on #256 I realised that #265 change should apply to both the observation and the discretised generation interval construction (this is useful when considering scenarios with different mean generation intervals).
This PR does this, plus adds a unit test. The unit tests to
LatentDelayare unchanged because this default is now inherited fromcensored_pmf.Slight modification is that the inferred$\Delta d$ rather than integer.
D(right truncation value) is now rounded to nearest multiple of