Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pipeline #290

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Updating pipeline #290

merged 11 commits into from
Jun 17, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 commented Jun 17, 2024

This PR is aimed at addressing two issues, I found it tricky to sensibly separate them.

Pipeline update to work with latest version of EpiAware

  • Fixes where prepended missing data were causing errors.
  • Update of observation model so that the latest helper version of day of week effect on ascertainment was involved.

This closes #287 .

Modify setting observation model for pipeline

Given we are changing the observation model to reflect changes in EpiAware it was easier to refactor so the observation model wasn't hardcoded but rather a default constructor option (as per other aspects of pipeline).

This closes #288 .

Minor changes

@SamuelBrand1 SamuelBrand1 requested a review from seabbs June 17, 2024 10:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (e506f7d) to head (0ff4dc1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          47       47           
  Lines         490      490           
=======================================
  Hits          455      455           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 2b6ef61 Jun 17, 2024
10 checks passed
@seabbs seabbs deleted the fix-obs-model-pipeline branch June 17, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment