Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aqua.jl - check package "quality" indicators #31

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Add Aqua.jl - check package "quality" indicators #31

merged 5 commits into from
Feb 13, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Feb 12, 2024

Aqua.jl checks a range of package "quality" measures and is integrated within the TestItems framework. I have added it here.

Note that this PR is a work in progress as Aqua.test_all() flags a range of package issues though some of these may be false positives.

I will resolve this but if any stick out as being obviously wrong please do flag ASAP.

@SamuelBrand1
Copy link
Collaborator

Looking at the CI error Aqua.jl might not be compatible with the function generation that is defined by the macro @model from Turing. But not sure.

@seabbs seabbs marked this pull request as ready for review February 12, 2024 23:07
@SamuelBrand1
Copy link
Collaborator

Looks like its working now! LGTM.

@seabbs seabbs merged commit e919a71 into main Feb 13, 2024
2 checks passed
@seabbs seabbs deleted the add-aqua branch February 13, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants