Flesh out scenario details #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsusswein
force-pushed
the
22-scenario-details
branch
from
ba624df to
70ab1bb
Compare
seabbs
force-pushed
the
22-scenario-details
branch
from
70ab1bb to
77da0a1
Compare
seabbs
reviewed
Feb 13, 2024
seabbs
reviewed
Feb 13, 2024
seabbs
reviewed
Feb 13, 2024
This is a first crack at some of the details we need to get scnearios started. I made the following big-er juddgement calls: * Renewal is good enough (vs SEIR) * One longer timeseries with crazy dynamics works because of the rolling windows * Put numbers on the GIs Closes #22
seabbs
force-pushed
the
22-scenario-details
branch
from
77da0a1 to
bbdd39d
Compare
|
As discussed today some of the review comments are not appropriate as this is a fleshing out of the skeleton vs a full method write up. I think we should make the minor correction we can here and then spin out specific issues that can be addressed in their own PRs so we can keep the development cadence up. @zsusswein give me a ping if there is anything I can help resolve here to get this PR turned around. |
Co-authored-by: Sam Abbott <[email protected]>
|
Where are we on t his? |
|
Nearly ready for another review? |
Got snowed under by pipeline stuff yesterday. Plan is to turn around this afternoon. |
Co-authored-by: Samuel Brand <[email protected]>
seabbs
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first crack at some of the details we need to get scenarios
started. I made the following big-er judgement calls:
rolling windows
Closes #22