-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a proposed modular API to specify a data (i.e. case) generating process #39
Conversation
…of RW so it doesn't double assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice. It feels a little still like there is a mixture of styles going on here for the different parts of the model (as in the issue) it would be great to have a little more clarity on that.
I think we might be best places though to review this design as it stands and then do another round if issue/PR iteration?
I've only sight read for now so will circle back once I have looked over the code locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go once issues have been resolved (i.e. moved to issues) as is. I do think there is a bit more conversation to be had about the precise modular construction of the model but I think we can iterate on this over time and should move on to postprocessing and formulating the different models likely first.
This PR introduces the modular API to the data generating process discussed in #38 .
Major additions
Diagrammatically, the "modules" (in workflow rather than Julia sense) that are implemented are below. Dotted lines fill in the currently unimplemented steps.
Unit tests are in test scripts here.
A script to run in
TestDev
mode which demonstrates the currently implemented steps is here.Minor additions
const
object to a simple construction functionMissing feature
I have not implemented docstrings in some functions here ahead of addressing #35
Closes #38
Closes #15