Issue 481: prior predictive analysis #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="481-prior-predictive-analysis", subdir="EpiAware")
using EpiAware |
|
Noting that
Context: This passed for |
seabbs
previously approved these changes
Oct 10, 2024
|
Since #491 has passed and in queue I'm merging modified CI into this. |
seabbs
approved these changes
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
- Coverage 90.02% 89.56% -0.47%
==========================================
Files 57 51 -6
Lines 742 738 -4
==========================================
- Hits 668 661 -7
- Misses 74 77 +3 ☔ View full report in Codecov by Sentry. |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Rt-without-renewal/Rt-without-renewalJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Multiple examples are redundant in prior pred modelling here
seabbs
force-pushed
the
481-prior-predictive-analysis
branch
from
40f1a27 to
557844f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #481.
This PR has a minor change to the prior predictive script, which was repeating the prior predictive analysis 4x.
Mainly this PR is adding a section to the manuscript supporting information describing the "first pass" priors and how for some combinations even prior predictive runs imply such large number of infections that we get
InexactErrorexceptions in sampling to discrete outcomes.To replicate locally run
and previewing or rendering the manuscript generates the following analysis of numbers of sucessful and failed prior predictive runs grouped by IGP and latent model.
I think that the next steps are pretty straightforward, but thats out of scope for this PR.