Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 511: Use benchmarkCI with DiffEqBase #517

Closed
wants to merge 4 commits into from

Conversation

SamuelBrand1
Copy link
Collaborator

This is a small PR aimed at resolving #511 by pointing the benchmark CI usage of BenchmarkCI.jl toward the fork hosted at https://github.com/SamuelBrand1/BenchmarkCI.jl.

Closes #511 .

@SamuelBrand1 SamuelBrand1 requested a review from seabbs November 5, 2024 23:57
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="fix-benchmark-ci", subdir="EpiAware")
using EpiAware

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (bc701a6) to head (0acf90e).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           sciml-infection-model     #517   +/-   ##
======================================================
  Coverage                  90.16%   90.16%           
======================================================
  Files                         56       56           
  Lines                        824      824           
======================================================
  Hits                         743      743           
  Misses                        81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelBrand1
Copy link
Collaborator Author

The error is:

ERROR: /home/runner/work/Rt-without-renewal/Rt-without-renewal is dirty. Please commit/stash your changes before benchmarking a specific commit
Stacktrace:
[1] error(::String, ::String)
@ Base ./error.jl:44
[2] benchmarkpkg(pkg::String, target::PkgBenchmark.BenchmarkConfig; script::String, postprocess::Nothing, resultfile::String, retune::Bool, verbose::Bool, logger_factory::Type, progressoptions::Nothing, custom_loadpath::String)
@ PkgBenchmark ~/.julia/packages/PkgBenchmark/nuPay/src/runbenchmark.jl:136
[3] benchmarkpkg
@ ~/.julia/packages/PkgBenchmark/nuPay/src/runbenchmark.jl:44 [inlined]
[4] macro expansion
@ ./timing.jl:421 [inlined]
[5] (::BenchmarkCI.var"#17#19"{PkgBenchmark.BenchmarkConfig, PkgBenchmark.BenchmarkConfig, String, String, @NamedTuple{retune::Bool, logger_factory::DataType, script::String}, Dict{Symbol, SubString{String}}, Dict{Symbol, SubString{String}}})()
@ BenchmarkCI ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:385
[6] noisily(f::BenchmarkCI.var"#17#19"{PkgBenchmark.BenchmarkConfig, PkgBenchmark.BenchmarkConfig, String, String, @NamedTuple{retune::Bool, logger_factory::DataType, script::String}, Dict{Symbol, SubString{String}}, Dict{Symbol, SubString{String}}}, yes::Bool; interval::Int64)
@ BenchmarkCI ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:361
[7] noisily(f::Function, yes::Bool)
@ BenchmarkCI ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:353
[8] noisily
@ ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:353 [inlined]
[9] _judge(; target::PkgBenchmark.BenchmarkConfig, baseline::PkgBenchmark.BenchmarkConfig, workspace::String, pkgdir::String, benchmarkdir::String, benchmarkpkg_kwargs::@NamedTuple{retune::Bool, logger_factory::DataType, script::String})
@ BenchmarkCI ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:374
[10] (::BenchmarkCI.var"#10#12"{String, String, String, DataType, @kwargs{retune::Bool}, PkgBenchmark.BenchmarkConfig, String})(tmpproject::String, should_resolve::Bool)
@ BenchmarkCI ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:338
[11] maybe_with_merged_project(f::BenchmarkCI.var"#10#12"{String, String, String, DataType, @kwargs{retune::Bool}, PkgBenchmark.BenchmarkConfig, String}, project::String, pkgdir::String)
@ BenchmarkCI ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:232
[12] judge(target::Nothing, baseline::String; workspace::String, pkgdir::String, script::String, project::String, logger_factory::Type, kwargs::@kwargs{retune::Bool})
@ BenchmarkCI ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:332
[13] #judge#7
@ ~/.julia/packages/BenchmarkCI/TdKsj/src/BenchmarkCI.jl:287 [inlined]
[14] top-level scope
@ none:1
Error: Process completed with exit code 1.

@SamuelBrand1
Copy link
Collaborator Author

Any ideas @seabbs ? It looks like something about starting with a new BenchmarkCI is causing an error?

@SamuelBrand1
Copy link
Collaborator Author

NB this approach differs from #519 in that this approach also adds a benchmark.

@seabbs seabbs closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants